Changeset 43729 for branches/5.0/src/wp-includes/post.php

Timestamp:

10/15/2018 11:45:16 AM (8 years ago)

Author:

flixos90

Message:

REST API: Move object type-specific metadata integrations from the wrapper functions to the low-level Meta API functions.

Object type-specific actions that should happen before or after modification of metadata have so far been part of the respective wrapper functions. By using action and filter hooks, this changeset ensures they are always executed, even when calling the lower-level Meta API functions directly, which the REST API does as a prime example.

Props flixos90, spacedmonkey.
Fixes #44467.

File:

• branches/5.0/src/wp-includes/post.php (modified) (5 diffs)

branches/5.0/src/wp-includes/post.php

@@ -1785 +1785 @@
 function add_post_meta( $post_id, $meta_key, $meta_value, $unique = false ) {
         // Make sure meta is added to the post, not a revision.
-        if ( $the_post = wp_is_post_revision($post_id) )
+        $the_post = wp_is_post_revision( $post_id );
+        if ( $the_post ) {
                 $post_id = $the_post;
-
-        $added = add_metadata( 'post', $post_id, $meta_key, $meta_value, $unique );
-        if ( $added ) {
-                wp_cache_set( 'last_changed', microtime(), 'posts' );
-        }
-        return $added;
+        }
+
+        return add_metadata( 'post', $post_id, $meta_key, $meta_value, $unique );
 }
 
@@ -1812 +1810 @@
 function delete_post_meta( $post_id, $meta_key, $meta_value = '' ) {
         // Make sure meta is added to the post, not a revision.
-        if ( $the_post = wp_is_post_revision($post_id) )
+        $the_post = wp_is_post_revision( $post_id );
+        if ( $the_post ) {
                 $post_id = $the_post;
-
-        $deleted = delete_metadata( 'post', $post_id, $meta_key, $meta_value );
-        if ( $deleted ) {
-                wp_cache_set( 'last_changed', microtime(), 'posts' );
-        }
-        return $deleted;
+        }
+
+        return delete_metadata( 'post', $post_id, $meta_key, $meta_value );
 }
 
@@ -1858 +1854 @@
 function update_post_meta( $post_id, $meta_key, $meta_value, $prev_value = '' ) {
         // Make sure meta is added to the post, not a revision.
-        if ( $the_post = wp_is_post_revision($post_id) )
+        $the_post = wp_is_post_revision( $post_id );
+        if ( $the_post ) {
                 $post_id = $the_post;
-
-        $updated = update_metadata( 'post', $post_id, $meta_key, $meta_value, $prev_value );
-        if ( $updated ) {
-                wp_cache_set( 'last_changed', microtime(), 'posts' );
-        }
-        return $updated;
+        }
+
+        return update_metadata( 'post', $post_id, $meta_key, $meta_value, $prev_value );
 }
 
@@ -1877 +1871 @@
  */
 function delete_post_meta_by_key( $post_meta_key ) {
-        $deleted = delete_metadata( 'post', null, $post_meta_key, '', true );
-        if ( $deleted ) {
-                wp_cache_set( 'last_changed', microtime(), 'posts' );
-        }
-        return $deleted;
+        return delete_metadata( 'post', null, $post_meta_key, '', true );
 }
 
@@ -6476 +6466 @@
         return $clauses;
 }
+
+/**
+ * Sets the last changed time for the 'posts' cache group.
+ *
+ * @since 5.0.0
+ */
+function wp_cache_set_posts_last_changed() {
+        wp_cache_set( 'last_changed', microtime(), 'posts' );
+}