Changeset 43756

Timestamp:

10/18/2018 08:31:58 PM (6 years ago)

Author:

danielbachhuber

Message:

REST API: Correct HTTP status code in error for requests to create a duplicate term.

The 409 error code is intended for situations where it is expected that the user will resolve the conflict and resubmit the same request. We use 400 error codes for other routes when a duplicate request is made. The 400 status code tells the user they need to modify their request for it to be successful.

Props shooper.
Merges [42354] to the 5.0 branch.
Fixes #42781. See #41370.

Location:

branches/5.0

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-categories-controller.php (modified) (1 diff)

branches/5.0/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -419 +419 @@
                 $existing_term = get_term( $term_id, $this->taxonomy );
                 $term->add_data( $existing_term->term_id, 'term_exists' );
-                $term->add_data( array( 'status' => 409, 'term_id' => $term_id ) );
+                $term->add_data( array( 'status' => 400, 'term_id' => $term_id ) );
             }
 

branches/5.0/tests/phpunit/tests/rest-api/rest-categories-controller.php

@@ -698 +698 @@
 
         $response = $this->server->dispatch( $request );
-        $this->assertEquals( 409, $response->get_status() );
+        $this->assertEquals( 400, $response->get_status() );
         $data = $response->get_data();
         $this->assertEquals( 'term_exists', $data['code'] );