Changeset 43819 for branches/5.0/src/wp-includes/post.php

Timestamp:

10/24/2018 04:32:29 PM (6 years ago)

Author:

jorbin

Message:

php7.3 compatibility: Fix compact throwing notices

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact

This fixes all unit tested code that uses compact.

Props desrosj.
Fixes #44416.

File:

• branches/5.0/src/wp-includes/post.php (modified) (2 diffs)

branches/5.0/src/wp-includes/post.php

@@ -3416 +3416 @@
     }
 
+    $new_postarr = array_merge(
+        array(
+            'ID' => $post_ID,
+        ),
+        compact( array_diff( array_keys( $defaults ), array( 'context', 'filter' ) ) )
+    );
+
     /**
      * Filters the post parent -- used to check for and prevent hierarchy loops.
@@ -3426 +3433 @@
      * @param array $postarr     Array of sanitized, but otherwise unmodified post data.
      */
-    $post_parent = apply_filters( 'wp_insert_post_parent', $post_parent, $post_ID, compact( array_keys( $postarr ) ), $postarr );
+    $post_parent = apply_filters( 'wp_insert_post_parent', $post_parent, $post_ID, $new_postarr, $postarr );
 
     /*