Changeset 4383 for trunk/wp-admin/admin-functions.php

Timestamp:

10/13/2006 12:23:25 AM (19 years ago)

Author:

markjaquith

Message:

cleanup [4382] a bit

File:

• trunk/wp-admin/admin-functions.php (modified) (3 diffs)

trunk/wp-admin/admin-functions.php

@@ -984 +984 @@
 
         if ( is_serialized($entry['meta_value']) ) {
-            if ( 's' == $entry['meta_value']{0} ) {
+            if ( is_serialized_string($entry['meta_value']) ) {
                 // this is a serialized string, so we should display it
                 $entry['meta_value'] = maybe_unserialize($entry['meta_value']);
@@ -1069 +1069 @@
     $metakeyselect = $wpdb->escape(stripslashes(trim($_POST['metakeyselect'])));
     $metakeyinput = $wpdb->escape(stripslashes(trim($_POST['metakeyinput'])));
-    $metavalue = prepare_data(stripslashes((trim($_POST['metavalue']))));
+    $metavalue = maybe_serialize(stripslashes((trim($_POST['metavalue']))));
     $metavalue = $wpdb->escape($metavalue);
 
@@ -1101 +1101 @@
 function update_meta($mid, $mkey, $mvalue) {
     global $wpdb;
-    if ( is_serialized(stripslashes($mvalue)) ) // $mvalue looks to be already serialized, so we should serialize it again to prevent the data from coming out in a different form than it came in
-        $mvalue = serialize($mvalue);
+    $mvalue = maybe_serialize(stripslashes($mvalue));
+    $mvalue = $wpdb->escape($mvalue);
     $mid = (int) $mid;
     return $wpdb->query("UPDATE $wpdb->postmeta SET meta_key = '$mkey', meta_value = '$mvalue' WHERE meta_id = '$mid'");