Changeset 43839 for branches/5.0

Timestamp:

10/29/2018 04:02:40 AM (8 years ago)

Author:

pento

Message:

Meta boxes: Don't show the block editor incompatiblity message when it doesn't apply.

We should only be showing this message in the classic editor interface, for meta boxes that are marked as being incompatible with the block editor.

Fixes #45207.

File:

• branches/5.0/src/wp-admin/includes/template.php (modified) (3 diffs)

branches/5.0/src/wp-admin/includes/template.php

@@ -1053 +1053 @@
                                                 continue;
 
+                                        $block_compatible = true;
                                         if ( is_array( $box[ 'args' ] ) ) {
                                                 // If a meta box is just here for back compat, don't show it in the block editor.
@@ -1064 +1065 @@
                                                 }
 
-                                                $block_compatible = true;
                                                 if ( isset( $box['args']['__block_editor_compatible_meta_box'] ) ) {
                                                         $block_compatible = (bool) $box['args']['__block_editor_compatible_meta_box'];
@@ -1096 +1096 @@
                                         echo '<div class="inside">' . "\n";
 
-                                        if ( WP_DEBUG && ! $screen->is_block_editor() && ! isset( $_GET['meta-box-loader'] ) ) {
+                                        if ( WP_DEBUG && ! $block_compatible && 'edit' === $screen->parent_base && ! $screen->is_block_editor() && ! isset( $_GET['meta-box-loader'] ) ) {
                                                 if ( is_array( $box['callback'] ) ) {
                                                         $reflection = new ReflectionMethod( $box['callback'][0], $box['callback'][1] );