Changeset 43859 for branches/5.0/src/wp-includes/class-wp-dependency.php

Timestamp:

11/01/2018 01:50:59 PM (7 years ago)

Author:

herregroen

Message:

I18N: Improve JavaScript translation support.

Improves upon [43825] by adding unit tests to cover additional use-cases and changes loading translations to only occur when outputting the script to allow setting translations on dependencies.

Props atimmer, omarreiss, nerrad, swissspidy, ocean90.
Fixes #45103.

File:

• branches/5.0/src/wp-includes/class-wp-dependency.php (modified) (2 diffs)

branches/5.0/src/wp-includes/class-wp-dependency.php

@@ -69 +69 @@
 
     /**
+     * Translation textdomain set for this dependency.
+     *
+     * @since 5.0.0
+     * @var string
+     */
+    public $textdomain;
+
+    /**
+     * Translation path set for this dependency.
+     *
+     * @since 5.0.0
+     * @var string
+     */
+    public $translations_path;
+
+    /**
      * Setup dependencies.
      *
@@ -95 +111 @@
     }
 
+    public function set_translations( $domain, $path = null ) {
+        if ( !is_string($domain) )
+            return false;
+        $this->textdomain        = $domain;
+        $this->translations_path = $path;
+        return true;
+    }
 }