Changeset 43859 for branches/5.0/src/wp-includes/functions.wp-scripts.php

Timestamp:

11/01/2018 01:50:59 PM (6 years ago)

Author:

herregroen

Message:

I18N: Improve JavaScript translation support.

Improves upon [43825] by adding unit tests to cover additional use-cases and changes loading translations to only occur when outputting the script to allow setting translations on dependencies.

Props atimmer, omarreiss, nerrad, swissspidy, ocean90.
Fixes #45103.

File:

• branches/5.0/src/wp-includes/functions.wp-scripts.php (modified) (2 diffs)

branches/5.0/src/wp-includes/functions.wp-scripts.php

@@ -194 +194 @@
 
 /**
- * Register translated strings for a script.
+ * Sets translated strings for a script.
  *
  * Works only if the script has already been added.
  *
  * @see WP_Scripts::set_translations()
- * @link https://core.trac.wordpress.org/ticket/45103
  * @global WP_Scripts $wp_scripts The WP_Scripts object for printing scripts.
  *
@@ -215 +214 @@
         _wp_scripts_maybe_doing_it_wrong( __FUNCTION__ );
         return false;
-    }
-
-    if ( ! wp_script_is( $handle, 'enqueued' ) ) {
-        _doing_it_wrong( __FUNCTION__, __( 'Script translations may only be set if the script is enqueued.' ), '5.0.0' );
     }