Changeset 43885 for branches/5.0/src/wp-admin/includes/meta-boxes.php

Timestamp:

11/12/2018 03:37:41 AM (6 years ago)

Author:

pento

Message:

Block Editor: Hide the Custom Fields meta box option if that meta box has been removed.

Some plugins remove the Custom Fields meta box, particularly when they provide functionality that replaces it. The block editor would correctly not display this meta box in these circumstances, but it still showed the option to display or hide it.

Props pento, noisysocks.
See #45282.

File:

• branches/5.0/src/wp-admin/includes/meta-boxes.php (modified) (1 diff)

branches/5.0/src/wp-admin/includes/meta-boxes.php

@@ -1362 +1362 @@
 
     if ( post_type_supports($post_type, 'custom-fields') ) {
-        $screen = get_current_screen();
-        if ( ! $screen || ! $screen->is_block_editor() || (bool) get_user_meta( get_current_user_id(), 'enable_custom_fields', true ) ) {
-            add_meta_box('postcustom', __('Custom Fields'), 'post_custom_meta_box', null, 'normal', 'core', array( '__back_compat_meta_box' => false, '__block_editor_compatible_meta_box' => true ) );
-        }
+        $args = array(
+            '__back_compat_meta_box' => ! (bool) get_user_meta( get_current_user_id(), 'enable_custom_fields', true ),
+            '__block_editor_compatible_meta_box' => true
+        );
+        add_meta_box('postcustom', __('Custom Fields'), 'post_custom_meta_box', null, 'normal', 'core', $args );
     }