Changeset 43892 for branches/5.0/src/wp-content/themes/twentynineteen/comments.php

Timestamp:

11/12/2018 11:19:13 PM (6 years ago)

Author:

allancole

Message:

Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.

This update applies the following changes:

• Improve menu UI to support keyboard, click and touch interactions
• Improve variable scoping and js performance in menu interaction javascript
• Improve custom-colors for selected text, buttons and menu hover styles
• Improve margins structure for more consistency between editor and frontend
• Improve discussion avatars for simpler wording and better performance
• Improve fonts in list widgets and list blocks
• Improve comment responsive spacing and avatar display
• Improve various block styles to make them consistent between the editor and frontend
• Add tabbed browsing support for ie11
• Add backwards compatibility support for older versions of WordPress
• Add fallback styles for older versions of WP where Gutenberg is activated and then deactivated (backwards compatibility)
• Add sizes attribute for featured images to improve responsive performance
• Add focus-within polyfill
• Add a footer menu for secondary page links
• Fix editor styles to prevent conflicts with plugins that add meta boxes to the editor
• Fix columns block issues on small screens
• Fix empty-space font text cursor issue in Gutenberg editor
• Fix RTL floating styles so that left/right floats are honored
• Fix cover image block margins/padding
• Fix invalid rgba style
• Fix php warning when returning attributes
• Fix gallery widget margins to improve gallery grids
• Fix .entry-content selectors to prevent shortcodes, plugins and other unknown content from breaking the layout
• Remove translation escaping to follow code standards in previous default themes
• Remove custom color output in the fronten header when default color is selected
• Remove fly-out sub-sub-sub-menu behavior on desktop to prevent sub-menus from falling off the screen
• General code clean up and coding standards improvements

Initial development occurred on GitHub. See: ​https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa, @tlxo, @themeroots, @whizbangik, @yingles, @youthkee, @brentswisher, @smy315, @ahmadawais, @desi-developer.

File:

• branches/5.0/src/wp-content/themes/twentynineteen/comments.php (modified) (4 diffs)

branches/5.0/src/wp-content/themes/twentynineteen/comments.php

@@ -22 +22 @@
 }
 
+$discussion = twentynineteen_get_discussion_data();
 ?>
 
 <div id="comments" class="<?php echo comments_open() ? 'comments-area' : 'comments-area comments-closed'; ?>">
-    <div class="<?php echo twentynineteen_get_discussion_data()->responses > 0 ? 'comments-title-wrap' : 'comments-title-wrap no-responses'; ?>">
+    <div class="<?php echo $discussion->responses > 0 ? 'comments-title-wrap' : 'comments-title-wrap no-responses'; ?>">
         <h2 class="comments-title">
         <?php
             if ( comments_open() ) {
                 if ( have_comments() ) {
-                    esc_html_e( 'Join the Conversation', 'twentynineteen' );
+                    _e( 'Join the Conversation', 'twentynineteen' );
                 } else {
-                    esc_html_e( 'Leave a comment', 'twentynineteen' );
+                    _e( 'Leave a comment', 'twentynineteen' );
                 }
             } else {
-                $comments_number = get_comments_number();
-                if ( '1' === $comments_number ) {
+                if ( '1' == $discussion->responses ) {
                     /* translators: %s: post title */
                     printf( _x( 'One reply on &ldquo;%s&rdquo;', 'comments title', 'twentynineteen' ), get_the_title() );
@@ -45 +45 @@
                             '%1$s reply on &ldquo;%2$s&rdquo;',
                             '%1$s replies on &ldquo;%2$s&rdquo;',
-                            $comments_number,
+                            $discussion->responses,
                             'comments title',
                             'twentynineteen'
                         ),
-                        number_format_i18n( $comments_number ),
+                        number_format_i18n( $discussion->responses ),
                         get_the_title()
                     );
@@ -103 +103 @@
             ?>
             <div class="comment-form-flex">
-                <span class="screen-reader-text"><?php esc_html_e( 'Leave a comment', 'twentynineteen' ); ?></span>
+                <span class="screen-reader-text"><?php _e( 'Leave a comment', 'twentynineteen' ); ?></span>
                 <?php twentynineteen_comment_form( 'asc' ); ?>
-                <h2 class="comments-title" aria-hidden="true"><?php esc_html_e( 'Leave a comment', 'twentynineteen' ); ?></h2>
+                <h2 class="comments-title" aria-hidden="true"><?php _e( 'Leave a comment', 'twentynineteen' ); ?></h2>
             </div>
             <?php
@@ -114 +114 @@
             ?>
             <p class="no-comments">
-                <?php esc_html_e( 'Comments are closed.', 'twentynineteen' ); ?>
+                <?php _e( 'Comments are closed.', 'twentynineteen' ); ?>
             </p>
             <?php