WordPress.org

Make WordPress Core


Ignore:
Timestamp:
11/12/2018 11:19:13 PM (7 months ago)
Author:
allancole
Message:

Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.

This update applies the following changes:

  • Improve menu UI to support keyboard, click and touch interactions
  • Improve variable scoping and js performance in menu interaction javascript
  • Improve custom-colors for selected text, buttons and menu hover styles
  • Improve margins structure for more consistency between editor and frontend
  • Improve discussion avatars for simpler wording and better performance
  • Improve fonts in list widgets and list blocks
  • Improve comment responsive spacing and avatar display
  • Improve various block styles to make them consistent between the editor and frontend
  • Add tabbed browsing support for ie11
  • Add backwards compatibility support for older versions of WordPress
  • Add fallback styles for older versions of WP where Gutenberg is activated and then deactivated (backwards compatibility)
  • Add sizes attribute for featured images to improve responsive performance
  • Add focus-within polyfill
  • Add a footer menu for secondary page links
  • Fix editor styles to prevent conflicts with plugins that add meta boxes to the editor
  • Fix columns block issues on small screens
  • Fix empty-space font text cursor issue in Gutenberg editor
  • Fix RTL floating styles so that left/right floats are honored
  • Fix cover image block margins/padding
  • Fix invalid rgba style
  • Fix php warning when returning attributes
  • Fix gallery widget margins to improve gallery grids
  • Fix .entry-content selectors to prevent shortcodes, plugins and other unknown content from breaking the layout
  • Remove translation escaping to follow code standards in previous default themes
  • Remove custom color output in the fronten header when default color is selected
  • Remove fly-out sub-sub-sub-menu behavior on desktop to prevent sub-menus from falling off the screen
  • General code clean up and coding standards improvements

Initial development occurred on GitHub. See: https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa, @tlxo, @themeroots, @whizbangik, @yingles, @youthkee, @brentswisher, @smy315, @ahmadawais, @desi-developer.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/5.0/src/wp-content/themes/twentynineteen/sass/site/primary/_comments.scss

    r43860 r43892  
    88
    99.comments-area {
     10    margin: calc(2 * #{$size__spacing-unit}) $size__spacing-unit;
     11    @include postContentMaxWidth();
     12
     13    @include media(tablet) {
     14        margin: calc(3 * #{$size__spacing-unit}) $size__site-margins;
     15    }
     16
     17    & > * {
     18        margin-top: calc(2 * #{$size__spacing-unit});
     19        margin-bottom: calc(2 * #{$size__spacing-unit});
     20
     21        @include media(tablet) {
     22            margin-top: calc(3 * #{$size__spacing-unit});
     23            margin-bottom: calc(3 * #{$size__spacing-unit});
     24        }
     25    }
    1026
    1127    /* Add extra margin when the comments section is located immediately after the
     
    1632    }
    1733
    18     .comment-list,
    19     .comment-navigation,
    20     > .comment-respond,
    21     .comment-form-flex,
    22     .no-comments {
    23         margin: calc(2 * #{$size__spacing-unit}) $size__spacing-unit;
    24 
    25         @include media(tablet) {
    26             margin: calc(3 * #{$size__spacing-unit}) calc(2 * (100vw / 12));
    27             max-width: calc(6 * (100vw / 12));
    28         }
    29     }
    30 
    3134    .comments-title-wrap {
    32 
    33         margin: calc(2 * #{$size__spacing-unit}) $size__spacing-unit;
    3435
    3536        @include media(tablet) {
     
    3738            display: flex;
    3839            justify-content: space-between;
    39             margin: calc(3 * #{$size__spacing-unit}) calc(2 * (100vw / 12));
    40             max-width: calc(8 * (100vw / 12));
    4140        }
    4241
     
    124123    }
    125124
    126     .pingback {
     125    .pingback,
     126    .trackback {
    127127
    128128        .comment-body {
     
    131131            font-size: $font__size-xs;
    132132            font-weight: 500;
     133            margin-top: $size__spacing-unit;
    133134            margin-bottom: $size__spacing-unit;
    134135
     
    151152
    152153.comment-reply {
    153     left: calc(#{$size__spacing-unit} + 100%);
    154     bottom: 0;
    155     position: absolute;
    156154
    157155    #respond + & {
     
    171169        padding-left: calc(.5 * (#{$size__spacing-unit} + calc(100vw / 12 )));
    172170
     171        &.depth-1,
    173172        .children {
    174173            padding-left: 0;
    175174        }
     175
     176        &.depth-1 {
     177            margin-left: calc(3.25 * #{$size__spacing-unit});
     178        }
    176179    }
    177180
    178181    .comment-body {
    179         margin: calc(2 * #{$size__spacing-unit}) 0;
    180     }
     182        margin: calc(2 * #{$size__spacing-unit}) 0 0;
     183    }
     184
    181185
    182186    .comment-meta {
    183187        position: relative;
    184 
    185         @include media(tablet) {
    186             display: flex;
    187         }
    188188    }
    189189
    190190    .comment-author {
    191 
    192         @include media(tablet) {
    193             flex: 0 0 auto;
    194             vertical-align: baseline;
    195         }
    196191
    197192        .avatar {
     
    212207            position: relative;
    213208            display: block;
    214 
    215             @include media(tablet) {
    216                 display: inline-block;
    217                 vertical-align: baseline;
    218             }
    219209
    220210            a {
     
    253243    .comment-metadata {
    254244
    255         @include media(tablet) {
    256             flex: 1 0 auto;
    257             margin-left: $size__spacing-unit;
    258             position: relative;
    259             vertical-align: baseline;
    260         }
    261 
    262245        > a,
    263246        .comment-edit-link {
    264             display: inline-block;
     247            display: inline;
    265248            font-weight: 500;
    266249            color: $color__text-light;
     
    272255
    273256            &:hover {
    274                 color: $color__text-hover;
     257                color: $color__link-hover;
    275258                text-decoration: none;
    276259            }
     
    313296        margin: $size__spacing-unit 0;
    314297
     298        @include media(desktop) {
     299            padding-right: $size__spacing-unit;
     300        }
     301
    315302        > *:first-child {
    316303            margin-top: 0;
     
    319306        > *:last-child {
    320307            margin-bottom: 0;
     308        }
     309
     310        blockquote {
     311            margin-left: 0;
    321312        }
    322313
Note: See TracChangeset for help on using the changeset viewer.