Changeset 43892 for branches/5.0/src/wp-content/themes/twentynineteen/template-parts/post/discussion-meta.php

Timestamp:

11/12/2018 11:19:13 PM (7 years ago)

Author:

allancole

Message:

Updating Twenty Nineteen, our new default theme for 2019, set for 5.0.

This update applies the following changes:

• Improve menu UI to support keyboard, click and touch interactions
• Improve variable scoping and js performance in menu interaction javascript
• Improve custom-colors for selected text, buttons and menu hover styles
• Improve margins structure for more consistency between editor and frontend
• Improve discussion avatars for simpler wording and better performance
• Improve fonts in list widgets and list blocks
• Improve comment responsive spacing and avatar display
• Improve various block styles to make them consistent between the editor and frontend
• Add tabbed browsing support for ie11
• Add backwards compatibility support for older versions of WordPress
• Add fallback styles for older versions of WP where Gutenberg is activated and then deactivated (backwards compatibility)
• Add sizes attribute for featured images to improve responsive performance
• Add focus-within polyfill
• Add a footer menu for secondary page links
• Fix editor styles to prevent conflicts with plugins that add meta boxes to the editor
• Fix columns block issues on small screens
• Fix empty-space font text cursor issue in Gutenberg editor
• Fix RTL floating styles so that left/right floats are honored
• Fix cover image block margins/padding
• Fix invalid rgba style
• Fix php warning when returning attributes
• Fix gallery widget margins to improve gallery grids
• Fix .entry-content selectors to prevent shortcodes, plugins and other unknown content from breaking the layout
• Remove translation escaping to follow code standards in previous default themes
• Remove custom color output in the fronten header when default color is selected
• Remove fly-out sub-sub-sub-menu behavior on desktop to prevent sub-menus from falling off the screen
• General code clean up and coding standards improvements

Initial development occurred on GitHub. See: ​https://github.com/WordPress/twentynineteen

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, aaronjorbin, netweb, b-07, khleomix, blowery, dereksmart, jasmussen, audrasjb, nielslange, mmaumio, dimadin, joyously, anevins12, peterwilsoncc, dannycooper, icaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, icaleb, grapplerulrich, ocean90, joshfeck, frankew, abdulwahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, mukeshpanchal27, burhandodhy, crunnells, Ismail-elkorchi, aryaprakasa, @tlxo, @themeroots, @whizbangik, @yingles, @youthkee, @brentswisher, @smy315, @ahmadawais, @desi-developer.

File:

• branches/5.0/src/wp-content/themes/twentynineteen/template-parts/post/discussion-meta.php (modified) (1 diff)

branches/5.0/src/wp-content/themes/twentynineteen/template-parts/post/discussion-meta.php

@@ -9 +9 @@
 
 /* Get data from current discussion on post. */
-$discussion = twentynineteen_get_discussion_data();
-
-$comments_number = get_comments_number();
-$has_responses   = $discussion->responses > 0;
+$discussion    = twentynineteen_get_discussion_data();
+$has_responses = $discussion->responses > 0;
 
 if ( $has_responses ) {
-    /* translators: %1(X responses)$s from %2(X others)$s */
-    $meta_label = sprintf(
-        '%1$s from %2$s.',
-        sprintf( _n( '%d response', '%d responses', $discussion->responses, 'twentynineteen' ), $discussion->responses ),
-        sprintf( _n( '%d other', '%d others', $discussion->commenters, 'twentynineteen' ), $discussion->commenters )
-    );
-} elseif ( $comments_number > 0 ) {
-    /* Show comment count if not enough discussion information */
-
-    $meta_label = sprintf( _n( '%d Comment', '%d Comments', $comments_number, 'twentynineteen' ), $comments_number );
+    /* translators: %1(X comments)$s */
+    $meta_label = sprintf( _n( '%d Comment', '%d Comments', $discussion->responses, 'twentynineteen' ), $discussion->responses );
 } else {
     $meta_label = __( 'No comments', 'twentynineteen' );