Changeset 43899

Timestamp:

11/15/2018 11:19:40 PM (6 years ago)

Author:

pento

Message:

Nav Menus: Fix a PHP 7.3 error when switching themes.

When switching themes, wp_map_nav_menu_locations() is used to ensure nav menus are placed in the relevant menu location. Occasionally, menus are registered to locations with numeric slugs, rather than strings. wp_map_nav_menu_locations() assumed it would be the latter, and ran stripos() on those numeric slugs. This behaviour is deprecated in PHP 7.3.

As this is the last known PHP 7.3 incompatibility, this commit also removes PHP 7.3 from Travis' allowed_failures list.

Props desrosj, jorbin.
See #45018.

Location:

branches/5.0

Files:

• .travis.yml (modified) (1 diff)
• src/wp-includes/nav-menu.php (modified) (2 diffs)
• tests/phpunit/tests/menu/nav-menu.php (modified) (1 diff)

branches/5.0/.travis.yml

@@ -32 +32 @@
   allow_failures:
   - php: nightly
-  - php: 7.3
 before_install:
 - |

branches/5.0/src/wp-includes/nav-menu.php

@@ -1140 +1140 @@
 
                 // ...actually match!
-                if ( false === stripos( $new_location, $slug ) && false === stripos( $slug, $new_location ) ) {
+                if ( is_string( $new_location ) && false === stripos( $new_location, $slug ) && false === stripos( $slug, $new_location ) ) {
+                    continue;
+                } elseif ( is_numeric( $new_location ) && $new_location !== $slug ) {
                     continue;
                 }
@@ -1151 +1153 @@
 
                         // ... have a match as well.
-                        if ( false === stripos( $location, $slug ) && false === stripos( $slug, $location ) ) {
+                        if ( is_string( $location ) && false === stripos( $location, $slug ) && false === stripos( $slug, $location ) ) {
+                            continue;
+                        } elseif ( is_numeric( $location ) && $location !== $slug ) {
                             continue;
                         }

branches/5.0/tests/phpunit/tests/menu/nav-menu.php

@@ -201 +201 @@
         $this->assertEqualSets( $expected_nav_menu_locations, $new_next_theme_nav_menu_locations );
     }
+
+    /**
+     * Technically possible old nav menu locations were registered numerically.
+     *
+     * @covers wp_map_nav_menu_locations()
+     */
+    public function test_numerical_old_locations() {
+        $this->register_nav_menu_locations( array( 'primary', 1 ) );
+
+        $old_nav_menu_locations = array(
+            'primary'  => 1,
+            'tertiary' => 2,
+            0          => 3,
+        );
+
+        $next_theme_nav_menu_locations     = array();
+        $new_next_theme_nav_menu_locations = wp_map_nav_menu_locations( $next_theme_nav_menu_locations, $old_nav_menu_locations );
+
+        $expected_nav_menu_locations = array(
+            'primary' => 1,
+            0         => 3,
+        );
+
+        $this->assertEqualSets( $expected_nav_menu_locations, $new_next_theme_nav_menu_locations );
+    }
 }