WordPress.org

Make WordPress Core


Ignore:
Timestamp:
11/15/2018 11:19:40 PM (11 months ago)
Author:
pento
Message:

Nav Menus: Fix a PHP 7.3 error when switching themes.

When switching themes, wp_map_nav_menu_locations() is used to ensure nav menus are placed in the relevant menu location. Occasionally, menus are registered to locations with numeric slugs, rather than strings. wp_map_nav_menu_locations() assumed it would be the latter, and ran stripos() on those numeric slugs. This behaviour is deprecated in PHP 7.3.

As this is the last known PHP 7.3 incompatibility, this commit also removes PHP 7.3 from Travis' allowed_failures list.

Props desrosj, jorbin.
See #45018.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/5.0/src/wp-includes/nav-menu.php

    r42026 r43899  
    11401140
    11411141                // ...actually match!
    1142                 if ( false === stripos( $new_location, $slug ) && false === stripos( $slug, $new_location ) ) {
     1142                if ( is_string( $new_location ) && false === stripos( $new_location, $slug ) && false === stripos( $slug, $new_location ) ) {
     1143                    continue;
     1144                } elseif ( is_numeric( $new_location ) && $new_location !== $slug ) {
    11431145                    continue;
    11441146                }
     
    11511153
    11521154                        // ... have a match as well.
    1153                         if ( false === stripos( $location, $slug ) && false === stripos( $slug, $location ) ) {
     1155                        if ( is_string( $location ) && false === stripos( $location, $slug ) && false === stripos( $slug, $location ) ) {
     1156                            continue;
     1157                        } elseif ( is_numeric( $location ) && $location !== $slug ) {
    11541158                            continue;
    11551159                        }
Note: See TracChangeset for help on using the changeset viewer.