Changeset 43908 for branches/5.0/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Timestamp:

11/19/2018 02:09:07 PM (7 years ago)

Author:

danielbachhuber

Message:

REST API: Include fields with null schema in get_fields_for_response().

In [43736], we prevented rendering fields when not present in ?_fields=. However, because get_fields_for_response() is dependent on get_item_schema(), any custom fields registered with a null schema would be incorrectly excluded from the response. Because the REST API permits a null schema for register_rest_field(), those fields should be included in the available fields for a response.

Fixes #45220.

File:

• branches/5.0/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (1 diff)

branches/5.0/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -520 +520 @@
         $schema = $this->get_item_schema();
         $fields = isset( $schema['properties'] ) ? array_keys( $schema['properties'] ) : array();
+
+        $additional_fields = $this->get_additional_fields();
+        foreach ( $additional_fields as $field_name => $field_options ) {
+            // For back-compat, include any field with an empty schema
+            // because it won't be present in $this->get_item_schema().
+            if ( is_null( $field_options['schema'] ) ) {
+                $fields[] = $field_name;
+            }
+        }
+
         if ( ! isset( $request['_fields'] ) ) {
             return $fields;