Changeset 43914

Timestamp:

11/21/2018 12:17:02 PM (6 years ago)

Author:

azaozz

Message:

TinyMCE: Run the "wp_editor_settings" and "disable_captions" filters for the Classic block. Fixes possible regressions in plugins that use these filters, also plugins that use them to add filters for the buttons, external plugins, etc.

Fixes #45348.

File:

• branches/5.0/src/wp-includes/script-loader.php (modified) (4 diffs)

branches/5.0/src/wp-includes/script-loader.php

@@ -487 +487 @@
  * Adds inline scripts required for the TinyMCE in the block editor.
  *
+ * These TinyMCE init settings are used to extend and override the default settings
+ * from `_WP_Editors::default_settings()` for the Classic block.
+ *
  * @since 5.0.0
  *
@@ -493 +496 @@
 function wp_tinymce_inline_scripts() {
     global $wp_scripts;
+
+    /** This filter is documented in wp-includes/class-wp-editor.php */
+    $editor_settings = apply_filters( 'wp_editor_settings', array( 'tinymce' => true ), 'classic-block' );
 
     $tinymce_plugins = array(
@@ -519 +525 @@
     $tinymce_plugins = array_unique( $tinymce_plugins );
 
+    $disable_captions = false;
+    // Runs after `tiny_mce_plugins` but before `mce_buttons`.
+    /** This filter is documented in wp-admin/includes/media.php */
+    if ( apply_filters( 'disable_captions', '' ) ) {
+        $disable_captions = true;
+    }
+
     $toolbar1 = array(
         'formatselect',
@@ -572 +585 @@
         'classic_block_editor' => true,
     );
+
+    if ( $disable_captions ) {
+        $tinymce_settings['wpeditimage_disable_captions'] = true;
+    }
+
+    if ( ! empty( $editor_settings['tinymce'] ) && is_array( $editor_settings['tinymce'] ) ) {
+        array_merge( $tinymce_settings, $editor_settings['tinymce'] );
+    }
 
     /* This filter is documented in wp-includes/class-wp-editor.php */