Changeset 43915

Timestamp:

11/21/2018 12:27:12 PM (8 years ago)

Author:

azaozz

Message:

TinyMCE: Fix the keyboard shortcut (Alt+Shift+H) to not open the default Block Editor help modal and change the title of the help modal to "Classic Block Keyboard Shortcuts" in the Classic BLock. Also remove Alt+Shift+Z in the Classic Block as it conflicts with the Block Editor.

Fixes #45365.

Location:

branches/5.0/src/wp-includes

Files:

• class-wp-editor.php (modified) (1 diff)
• js/tinymce/plugins/wordpress/plugin.js (modified) (3 diffs)

branches/5.0/src/wp-includes/class-wp-editor.php

@@ -1269 +1269 @@
                         // Shortcuts help modal
                         'Keyboard Shortcuts' => array( __( 'Keyboard Shortcuts' ), 'accessH' ),
+                        'Classic Block Keyboard Shortcuts' => __( 'Classic Block Keyboard Shortcuts' ),
                         'Default shortcuts,' => __( 'Default shortcuts,' ),
                         'Additional shortcuts,' => __( 'Additional shortcuts,' ),

branches/5.0/src/wp-includes/js/tinymce/plugins/wordpress/plugin.js

@@ -371 +371 @@
 
                 dialog = editor.windowManager.open( {
-                        title: 'Keyboard Shortcuts',
+                        title: editor.settings.classic_block_editor ? 'Classic Block Keyboard Shortcuts' : 'Keyboard Shortcuts',
                         items: {
                                 type: 'container',
@@ -653 +653 @@
                         o: 'InsertOrderedList',
                         m: 'WP_Medialib',
-                        z: 'WP_Adv',
                         t: 'WP_More',
                         d: 'Strikethrough',
-                        h: 'WP_Help',
                         p: 'WP_Page',
                         x: 'WP_Code'
@@ -668 +666 @@
                         }
                 } );
+
+                // Alt+Shift+Z removes a block in the Block Editor, don't add it to the Classic Block.
+                if ( ! editor.settings.classic_block_editor ) {
+                        editor.addShortcut( 'access+z', '', 'WP_Adv' );
+                }
+
+                // Workaround for not triggering the global help modal in the Block Editor by the Classic Block shortcut.
+                editor.on( 'keydown', function( event ) {
+                        if ( event.shiftKey && event.altKey && event.code === 'KeyH' ) {
+                                editor.execCommand( 'WP_Help' );
+                                event.stopPropagation();
+                                event.stopImmediatePropagation();
+                                return false;
+                        }
+
+                        return true;
+                });
 
                 if ( window.getUserSetting( 'editor_plain_text_paste_warning' ) > 1 ) {