Changeset 43942

Timestamp:

11/23/2018 08:34:44 AM (8 years ago)

Author:

youknowriad

Message:

Block Editor: Fix the WordPress packages and vendor script registration.

The version is set properly and the scripts are automatically loaded in the footer.
This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy.
Fixes #45402.
See #45396.

Location:

branches/5.0/src

Files:

• wp-admin/edit.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (3 diffs)

branches/5.0/src/wp-admin/edit.php

@@ -184 +184 @@
 
 if ( 'wp_block' === $post_type ) {
+        wp_enqueue_script( 'wp-list-reusable-blocks' );
         wp_enqueue_style( 'wp-list-reusable-blocks' );
-
-        // wp-list-reusable-blocks enhances the page's DOM and so needs to be loaded in the footer.
-        wp_enqueue_script( 'wp-list-reusable-blocks', '', array(), false, true );
 }
 

branches/5.0/src/wp-includes/script-loader.php

@@ -112 +112 @@
                 $version = $vendor_scripts_versions[ $handle ];
 
-                $scripts->add( $handle, $path, $dependencies, false, $version );
+                $scripts->add( $handle, $path, $dependencies, $version, 1 );
         }
 
@@ -211 +211 @@
                 'a11y' => '2.0.2',
                 'annotations' => '1.0.3',
-                'api-fetch' => '2.2.5',
                 'autop' => '2.0.2',
                 'blob' => '2.1.0',
@@ -469 +468 @@
                 $version = $packages_versions[ $package ];
 
-                $scripts->add( $handle, $path, $dependencies, false, $version );
+                $scripts->add( $handle, $path, $dependencies, $version, 1 );
 
                 if ( isset( $package_translations[ $package ] ) ) {