Changeset 43986 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Timestamp:

12/12/2018 08:50:22 PM (22 months ago)

Author:

desrosj

Message:

REST API: Don't add fields to object when not included in ?_fields=.

In [43087], we improved REST API performance by only rendering the fields specified in the request. Similarly, any fields registered with register_rest_field() should only be rendered when included in ?_fields=.

Props dlh, danielbachhuber.

Merges [43736] to trunk.

Fixes #45099.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -386 +386 @@
         $additional_fields = $this->get_additional_fields();
 
+        $requested_fields = $this->get_fields_for_response( $request );
+
         foreach ( $additional_fields as $field_name => $field_options ) {
 
             if ( ! $field_options['get_callback'] ) {
+                continue;
+            }
+
+            if ( ! in_array( $field_name, $requested_fields, true ) ) {
                 continue;
             }