Changeset 43986 for trunk/tests/phpunit/tests/rest-api/rest-test-controller.php

Timestamp:

12/12/2018 08:50:22 PM (3 years ago)

Author:

desrosj

Message:

REST API: Don't add fields to object when not included in ?_fields=.

In [43087], we improved REST API performance by only rendering the fields specified in the request. Similarly, any fields registered with register_rest_field() should only be rendered when included in ?_fields=.

Props dlh, danielbachhuber.

Merges [43736] to trunk.

Fixes #45099.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-test-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-test-controller.php

@@ -11 +11 @@
  */
 class WP_REST_Test_Controller extends WP_REST_Controller {
+    /**
+     * Prepares the item for the REST response.
+     *
+     * @param mixed           $item    WordPress representation of the item.
+     * @param WP_REST_Request $request Request object.
+     * @return WP_Error|WP_REST_Response Response object on success, or WP_Error object on failure.
+     */
+    public function prepare_item_for_response( $item, $request ) {
+        $context  = ! empty( $request['context'] ) ? $request['context'] : 'view';
+        $item     = $this->add_additional_fields_to_object( $item, $request );
+        $item     = $this->filter_response_by_context( $item, $context );
+        $response = rest_ensure_response( $item );
+        return $response;
+    }
 
     /**
-     * Get the Post type's schema, conforming to JSON Schema
+     * Get the item's schema, conforming to JSON Schema.
      *
      * @return array
@@ -73 +87 @@
         );
 
-        return $schema;
+        return $this->add_additional_fields_schema( $schema );
     }