Changeset 44019

Timestamp:

12/13/2018 12:05:32 AM (7 years ago)

Author:

pento

Message:

KSES: Conditionally remove the <form> element from $allowedposttags.

To avoid backwards compatibility issues, <form> is re-added if a custom filter has added the <input> or <select> elements to $allowedposttags.

Merges [43994] to the 3.7 branch.

Location:

branches/3.7

Files:

• . (modified) (1 prop)
• src (modified) (1 prop)
• src/wp-includes/kses.php (modified) (3 diffs)

branches/3.7/src/wp-includes/kses.php

@@ -159 +159 @@
             'lang' => true,
             'xml:lang' => true,
-        ),
-        'form' => array(
-            'action' => true,
-            'accept' => true,
-            'accept-charset' => true,
-            'enctype' => true,
-            'method' => true,
-            'name' => true,
-            'target' => true,
         ),
         'h1' => array(
@@ -565 +556 @@
  *
  * @since 3.5.0
+ * @since 5.0.1 `form` removed as allowable HTML tag.
  *
  * @param string $context The context for which to retrieve tags. Allowed values are
@@ -578 +570 @@
     switch ( $context ) {
         case 'post':
-            return apply_filters( 'wp_kses_allowed_html', $allowedposttags, $context );
+            $tags = apply_filters( 'wp_kses_allowed_html', $allowedposttags, $context );
+
+            // 5.0.1 removed the `<form>` tag, allow it if a filter is allowing it's sub-elements `<input>` or `<select>`.
+            if ( ! CUSTOM_TAGS && ! isset( $tags['form'] ) && ( isset( $tags['input'] ) || isset( $tags['select'] ) ) ) {
+                $tags = $allowedposttags;
+
+                $tags['form'] = array(
+                    'action' => true,
+                    'accept' => true,
+                    'accept-charset' => true,
+                    'enctype' => true,
+                    'method' => true,
+                    'name' => true,
+                    'target' => true,
+                );
+
+                /** This filter is documented in wp-includes/kses.php */
+                $tags = apply_filters( 'wp_kses_allowed_html', $tags, $context );
+            }
+
+            return $tags;
             break;
         case 'user_description':