Changeset 4402 for trunk/wp-includes/post-template.php

Timestamp:

10/17/2006 06:24:36 PM (20 years ago)

Author:

markjaquith

Message:

Entity encode image title attribute. Props mdawaffe. fixes #3258

File:

• trunk/wp-includes/post-template.php (modified) (4 diffs)

trunk/wp-includes/post-template.php

@@ -329 +329 @@
                 return __('Missing Attachment');
 
+        $post_title = wp_specialchars( $_post->post_title, 1 );
+
         if (! empty($_post->guid) ) {
                 $innerHTML = get_attachment_innerHTML($_post->ID, $fullsize, $max_dims);
 
-                return "<a href=\"{$_post->guid}\" title=\"{$_post->post_title}\" >{$innerHTML}</a>";
+                return "<a href='$_post->guid' title='$post_title'>$innerHTML</a>";
 
         } else {
@@ -401 +403 @@
                         if ( $actual_aspect >= $desired_aspect ) {
                                 $height = $actual_aspect * $max_dims[0];
-                                $constraint = "width=\"{$max_dims[0]}\" ";
+                                $constraint = "width='{$max_dims[0]}' ";
                                 $post->iconsize = array($max_dims[0], $height);
                         } else {
                                 $width = $max_dims[1] / $actual_aspect;
-                                $constraint = "height=\"{$max_dims[1]}\" ";
+                                $constraint = "height='{$max_dims[1]}' ";
                                 $post->iconsize = array($width, $max_dims[1]);
                         }
@@ -413 +415 @@
         }
 
-        $icon = "<img src=\"{$src}\" title=\"{$post->post_title}\" alt=\"{$post->post_title}\" {$constraint}/>";
+        $post_title = wp_specialchars( $post->post_title, 1 );
+
+        $icon = "<img src='$src' title='$post_title' alt='$post_title' $constraint/>";
 
         return apply_filters('attachment_icon', $icon, $post->ID);
@@ -426 +430 @@
         $post = & get_post($id);
 
-        $innerHTML = $post->post_title;
+        $innerHTML = wp_specialchars( $post->post_title, 1 );
 
         return apply_filters('attachment_innerHTML', $innerHTML, $post->ID);