Changeset 44153 for trunk/tests/phpunit/tests/admin/includesPost.php

Timestamp:

12/14/2018 03:16:56 AM (6 years ago)

Author:

desrosj

Message:

Meta: Allow empty strings to be set by Custom Fields meta box.

Because the REST API allows meta keys to have empty values, the Custom Fields meta box should permit the same behavior.

Props charlestonsw, soulseekah, danielbachhuber.

Merges [43811] to trunk.

Fixes #43559.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -800 +800 @@
         $this->assertSame( array( 'icon' => 'text' ), $blocks[ $name ] );
     }
+
+    /**
+     * @ticket 43559
+     */
+    public function test_post_add_meta_empty_is_allowed() {
+        $p = self::factory()->post->create();
+
+        $_POST = array(
+            'metakeyinput' => 'testkey',
+            'metavalue'    => '',
+        );
+
+        wp_set_current_user( self::$admin_id );
+
+        $this->assertNotFalse( add_meta( $p ) );
+        $this->assertEquals( '', get_post_meta( $p, 'testkey', true ) );
+    }
 }