WordPress.org

Make WordPress Core


Ignore:
Timestamp:
12/14/2018 05:12:12 AM (2 years ago)
Author:
desrosj
Message:

PHP7.3 compatibility: Fix compact throwing notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. The full RFC can be viewed here: https://wiki.php.net/rfc/compact.

Props jorbin, desrosj.

Merges [43819] and [43832] to trunk.

Fixes #44416.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk

  • trunk/src/wp-includes/class-wp-comment-query.php

    r42875 r44166  
    636636        $offset = absint( $this->query_vars['offset'] );
    637637        $paged  = absint( $this->query_vars['paged'] );
     638        $limits = '';
    638639
    639640        if ( ! empty( $number ) ) {
     
    820821        }
    821822
    822         $join = '';
     823        $join    = '';
     824        $groupby = '';
    823825
    824826        if ( $join_posts_table ) {
Note: See TracChangeset for help on using the changeset viewer.