Changeset 44166 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

12/14/2018 05:12:12 AM (6 years ago)

Author:

desrosj

Message:

PHP7.3 compatibility: Fix compact throwing notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

Props jorbin, desrosj.

Merges [43819] and [43832] to trunk.

Fixes #44416.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-comment-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -636 +636 @@
         $offset = absint( $this->query_vars['offset'] );
         $paged  = absint( $this->query_vars['paged'] );
+        $limits = '';
 
         if ( ! empty( $number ) ) {
@@ -820 +821 @@
         }
 
-        $join = '';
+        $join    = '';
+        $groupby = '';
 
         if ( $join_posts_table ) {