Changeset 44166 for trunk/src/wp-includes/post.php

Timestamp:

12/14/2018 05:12:12 AM (8 years ago)

Author:

desrosj

Message:

PHP7.3 compatibility: Fix compact throwing notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

Props jorbin, desrosj.

Merges [43819] and [43832] to trunk.

Fixes #44416.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-includes/post.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -3603 +3603 @@
         }
 
+        $new_postarr = array_merge(
+                array(
+                        'ID' => $post_ID,
+                ),
+                compact( array_diff( array_keys( $defaults ), array( 'context', 'filter' ) ) )
+        );
+
         /**
          * Filters the post parent -- used to check for and prevent hierarchy loops.
@@ -3613 +3620 @@
          * @param array $postarr     Array of sanitized, but otherwise unmodified post data.
          */
-        $post_parent = apply_filters( 'wp_insert_post_parent', $post_parent, $post_ID, compact( array_keys( $postarr ) ), $postarr );
+        $post_parent = apply_filters( 'wp_insert_post_parent', $post_parent, $post_ID, $new_postarr, $postarr );
 
         /*