Changeset 44166 for trunk/tests/phpunit/tests/dependencies/scripts.php

Timestamp:

12/14/2018 05:12:12 AM (6 years ago)

Author:

desrosj

Message:

PHP7.3 compatibility: Fix compact throwing notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

Props jorbin, desrosj.

Merges [43819] and [43832] to trunk.

Fixes #44416.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/dependencies/scripts.php (modified) (1 diff)

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -868 +868 @@
      */
     public function test_wp_enqueue_code_editor_when_generated_array_by_compact_will_be_passed() {
+        $file                   = '';
         $wp_enqueue_code_editor = wp_enqueue_code_editor( compact( 'file' ) );
         $this->assertNonEmptyMultidimensionalArray( $wp_enqueue_code_editor );