WordPress.org

Make WordPress Core

Changeset 44167 for trunk/.travis.yml


Ignore:
Timestamp:
12/14/2018 05:15:54 AM (15 months ago)
Author:
desrosj
Message:

Nav Menus: Fix a PHP 7.3 error when switching themes.

When switching themes, wp_map_nav_menu_locations() is used to ensure nav menus are placed in the relevant menu location. Occasionally, menus are registered to locations with numeric slugs, rather than strings. wp_map_nav_menu_locations() assumed it would be the latter, and ran stripos() on those numeric slugs. This behavior is deprecated in PHP 7.3.

As this is the last PHP 7.3 error in unit tests, this commit also removes PHP 7.3 from Travis' allowed_failures list.

Props pento, desrosj, jorbin.

Merges [43899] to trunk.

See #45018.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk

  • trunk/.travis.yml

    r43975 r44167  
    1313matrix:
    1414  include:
    15   - php: 7.3
    1615  - php: 7.2
    1716    env: WP_TRAVISCI=travis:format
    1817  - php: 7.1
    1918    env: WP_TRAVISCI=travis:js
     19  - php: 7.3
    2020  - php: 7.2
    2121  - php: 7.1
     
    3535  allow_failures:
    3636  - php: nightly
    37   - php: 7.3
    3837before_install:
    3938- |
Note: See TracChangeset for help on using the changeset viewer.