Changeset 44173

Timestamp:

12/14/2018 06:03:35 AM (6 years ago)

Author:

pento

Message:

REST API: Improve performance by avoiding call_user_func().

The get_compact_response_links() method was introduced in WP 4.5, and this conditional is no longer necessary.

Merges [43834] from the 5.0 branch to trunk.

Props schlessera, timothyblynjacobs.
Fixes #45189.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-includes/rest-api.php (modified) (1 diff)
• src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api.php

@@ -1368 +1368 @@
         $server = rest_get_server();
         $data   = (array) $response->get_data();
-        if ( method_exists( $server, 'get_compact_response_links' ) ) {
-            $links = call_user_func( array( $server, 'get_compact_response_links' ), $response );
-        } else {
-            $links = call_user_func( array( $server, 'get_response_links' ), $response );
-        }
+        $links  = $server->get_compact_response_links( $response );
         if ( ! empty( $links ) ) {
             $data['_links'] = $links;

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -213 +213 @@
         $data   = (array) $response->get_data();
         $server = rest_get_server();
-
-        if ( method_exists( $server, 'get_compact_response_links' ) ) {
-            $links = call_user_func( array( $server, 'get_compact_response_links' ), $response );
-        } else {
-            $links = call_user_func( array( $server, 'get_response_links' ), $response );
-        }
+        $links  = $server->get_compact_response_links( $response );
 
         if ( ! empty( $links ) ) {