Changeset 44175

Timestamp:

12/14/2018 09:41:56 AM (6 years ago)

Author:

atimmer

Message:

Meta boxes: Don't show the block editor incompatiblity message when it doesn't apply.

We should only be showing this message in the classic editor interface, for meta boxes that are marked as being incompatible with the block editor.

Props pento.
Merges [43839] to trunk.
Fixes #45207.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/template.php (modified) (3 diffs)

trunk/src/wp-admin/includes/template.php

@@ -1138 +1138 @@
                     }
 
+                    $block_compatible = true;
                     if ( is_array( $box[ 'args' ] ) ) {
                         // If a meta box is just here for back compat, don't show it in the block editor.
@@ -1149 +1150 @@
                         }
 
-                        $block_compatible = true;
                         if ( isset( $box['args']['__block_editor_compatible_meta_box'] ) ) {
                             $block_compatible = (bool) $box['args']['__block_editor_compatible_meta_box'];
@@ -1187 +1187 @@
                     echo '<div class="inside">' . "\n";
 
-                    if ( WP_DEBUG && ! $screen->is_block_editor() && ! isset( $_GET['meta-box-loader'] ) ) {
+                    if ( WP_DEBUG && ! $block_compatible && 'edit' === $screen->parent_base && ! $screen->is_block_editor() && ! isset( $_GET['meta-box-loader'] ) ) {
                         if ( is_array( $box['callback'] ) ) {
                             $reflection = new ReflectionMethod( $box['callback'][0], $box['callback'][1] );