Changeset 44184 for trunk/src/wp-admin/includes/class-ftp.php

Timestamp:

12/14/2018 12:25:16 PM (6 years ago)

Author:

atimmer

Message:

FTP/PemFTP Library: Fix some PHP notices.

ftp_base::glob() used each(), which is deprecated as of PHP 7.2.
ftp_base::fget() was missing the decleration of its third parameter, $rest.

Props itowhid06, pento.
Merges [43848] to trunk.
Fixes #44489.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-ftp.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-ftp.php

@@ -525 +525 @@
     }
 
-    function fget($fp, $remotefile,$rest=0) {
+    function fget($fp, $remotefile, $rest=0) {
         if($this->_can_restore and $rest!=0) fseek($fp, $rest);
         $pi=pathinfo($remotefile);
@@ -584 +584 @@
     }
 
-    function fput($remotefile, $fp) {
+    function fput($remotefile, $fp, $rest=0) {
         if($this->_can_restore and $rest!=0) fseek($fp, $rest);
         $pi=pathinfo($remotefile);
@@ -776 +776 @@
         } else $path=getcwd();
         if(is_array($handle) and !empty($handle)) {
-            while($dir=each($handle)) {
+            foreach($handle as $dir) {
                 if($this->glob_pattern_match($pattern,$dir))
                 $output[]=$dir;