Changeset 44196 for branches/5.0/src/wp-content/themes/twentynineteen/functions.php

Timestamp:

12/14/2018 09:23:52 PM (6 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github.com/WordPress/twentynineteen/pull/47
• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217

Props kjellr, allancole, dimadin, westonruter.

See #45424.

File:

• branches/5.0/src/wp-content/themes/twentynineteen/functions.php (modified) (2 diffs)

branches/5.0/src/wp-content/themes/twentynineteen/functions.php

@@ -222 +222 @@
     wp_style_add_data( 'twentynineteen-style', 'rtl', 'replace' );
 
-    wp_enqueue_script( 'twentynineteen-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', true );
-
     if ( has_nav_menu( 'menu-1' ) ) {
         wp_enqueue_script( 'twentynineteen-priority-menu', get_theme_file_uri( '/js/priority-menu.js' ), array(), '1.0', true );
@@ -236 +234 @@
 }
 add_action( 'wp_enqueue_scripts', 'twentynineteen_scripts' );
+
+/**
+ * Fix skip link focus in IE11.
+ *
+ * This does not enqueue the script because it is tiny and because it is only for IE11,
+ * thus it does not warrant having an entire dedicated blocking script being loaded.
+ *
+ * @link https://git.io/vWdr2
+ */
+function twentynineteen_skip_link_focus_fix() {
+    // The following is minified via `terser --compress --mangle -- js/skip-link-focus-fix.js`.
+    ?>
+    <script>
+        /(trident|msie)/i.test(navigator.userAgent)&&document.getElementById&&window.addEventListener&&window.addEventListener("hashchange",function(){var t,e=location.hash.substring(1);/^[A-z0-9_-]+$/.test(e)&&(t=document.getElementById(e))&&(/^(?:a|select|input|button|textarea)$/i.test(t.tagName)||(t.tabIndex=-1),t.focus())},!1);
+    </script>
+    <?php
+}
+add_action( 'wp_print_footer_scripts', 'twentynineteen_skip_link_focus_fix' );
 
 /**