Changeset 44199 for branches/5.0/src/wp-content/themes/twentynineteen/header.php

Timestamp:

12/14/2018 09:50:16 PM (6 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fixes some minor code quality issues. ​https://github.com/WordPress/twentynineteen/pull/237
• Fix PHP Warning: Parameter must be an array or an object that implements Countable. ​https://github.com/WordPress/twentynineteen/pull/661
• Add missing text domain and escaping to comment author text. ​https://github.com/WordPress/twentynineteen/pull/274
• Remove hyphens rule for cover image text. ​https://github.com/WordPress/twentynineteen/pull/691

Props khleomix, grapplerulrich, iCaleb, kjellr, allancole.

See #45424.

File:

• branches/5.0/src/wp-content/themes/twentynineteen/header.php (modified) (1 diff)

branches/5.0/src/wp-content/themes/twentynineteen/header.php

@@ -38 +38 @@
 
                         $classes = 'entry-header';
-                        if ( ! empty( $discussion ) && count( $discussion->responses ) > 0 ) {
+                        if ( ! empty( $discussion ) && absint( $discussion->responses ) > 0 ) {
                             $classes = 'entry-header has-discussion';
                         }