Changeset 44224 for trunk

Timestamp:

12/16/2018 01:58:41 AM (7 years ago)

Author:

jeremyfelt

Message:

Editor: Cast the result of the default_content, default_title, and default_excerpt filters.

If a plugin returns a non-string value (or returns null) on these filters, it can cause errors in the block editor. Casting them as a string prevents these errors.

Merges [43858] from the 5.0 branch to trunk.

Props dd32.
See #45236.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/post.php (modified) (3 diffs)

trunk/src/wp-admin/includes/post.php

@@ -684 +684 @@
      * @param WP_Post $post         Post object.
      */
-    $post->post_content = apply_filters( 'default_content', $post_content, $post );
+    $post->post_content = (string) apply_filters( 'default_content', $post_content, $post );
 
     /**
@@ -694 +694 @@
      * @param WP_Post $post       Post object.
      */
-    $post->post_title = apply_filters( 'default_title', $post_title, $post );
+    $post->post_title = (string) apply_filters( 'default_title', $post_title, $post );
 
     /**
@@ -704 +704 @@
      * @param WP_Post $post         Post object.
      */
-    $post->post_excerpt = apply_filters( 'default_excerpt', $post_excerpt, $post );
+    $post->post_excerpt = (string) apply_filters( 'default_excerpt', $post_excerpt, $post );
 
     return $post;