Changeset 44250 for trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

Timestamp:

12/17/2018 12:23:55 AM (7 years ago)

Author:

SergeyBiryukov

Message:

REST API: Avoid using 'parent' as path argument name for autosaves.

When 'parent' is set as the path argument name, it gets passed down through to the create_item() method and can erroneously reset the 'parent' value on the post itself. Instead, we rename the argument to 'id' and replicate the revision controller's get_items_permissions_check() to instead reference 'id'.

Also ensures revision query params (of which there are many) aren't exposed as the query params for autosaves (of which there are two).

Props TimothyBlynJacobs.
Merges [43897] to trunk.
See #43316.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-schema-setup.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

@@ -90 +90 @@
             '/wp/v2/posts/(?P<parent>[\\d]+)/revisions',
             '/wp/v2/posts/(?P<parent>[\\d]+)/revisions/(?P<id>[\\d]+)',
-            '/wp/v2/posts/(?P<parent>[\\d]+)/autosaves',
+            '/wp/v2/posts/(?P<id>[\\d]+)/autosaves',
             '/wp/v2/posts/(?P<parent>[\\d]+)/autosaves/(?P<id>[\\d]+)',
             '/wp/v2/pages',
@@ -96 +96 @@
             '/wp/v2/pages/(?P<parent>[\\d]+)/revisions',
             '/wp/v2/pages/(?P<parent>[\\d]+)/revisions/(?P<id>[\\d]+)',
-            '/wp/v2/pages/(?P<parent>[\\d]+)/autosaves',
+            '/wp/v2/pages/(?P<id>[\\d]+)/autosaves',
             '/wp/v2/pages/(?P<parent>[\\d]+)/autosaves/(?P<id>[\\d]+)',
             '/wp/v2/media',
@@ -102 +102 @@
             '/wp/v2/blocks',
             '/wp/v2/blocks/(?P<id>[\d]+)',
-            '/wp/v2/blocks/(?P<parent>[\d]+)/autosaves',
+            '/wp/v2/blocks/(?P<id>[\d]+)/autosaves',
             '/wp/v2/blocks/(?P<parent>[\d]+)/autosaves/(?P<id>[\d]+)',
             '/wp/v2/types',