Context Navigation

← Previous Change
Next Change →

class-wp-rest-controller.php

Timestamp:

12/17/2018 01:14:17 AM (8 years ago)

Author:

SergeyBiryukov

Message:

REST API: Include fields with null schema in get_fields_for_response().

In [43736], we prevented rendering fields when not present in ?_fields=. However, because get_fields_for_response() is dependent on get_item_schema(), any custom fields registered with a null schema would be incorrectly excluded from the response. Because the REST API permits a null schema for register_rest_field(), those fields should be included in the available fields for a response.

Props danielbachhuber.
Merges [43908] to trunk.
Fixes #45220.

Location:

trunk

Files:

: 2 edited

. (modified) (1 prop)
src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk
- Property svn:mergeinfo changed
  /branches/5.0 merged: 43908

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

-              r44173
+              r44254
                 $schema = $this->get_item_schema();
                 $fields = isset( $schema['properties'] ) ? array_keys( $schema['properties'] ) : array();
+                $additional_fields = $this->get_additional_fields();
+                foreach ( $additional_fields as $field_name => $field_options ) {
+                        // For back-compat, include any field with an empty schema
+                        // because it won't be present in $this->get_item_schema().
+                        if ( is_null( $field_options['schema'] ) ) {
+                                $fields[] = $field_name;
+                        }
+                }
                 if ( ! isset( $request['_fields'] ) ) {
                         return $fields;

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 44254 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Legend:

trunk

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Download in other formats: