Changeset 44269 for trunk/tests/phpunit/tests/blocks/block-type.php

Timestamp:

12/17/2018 05:59:44 PM (6 years ago)

Author:

desrosj

Message:

REST API: Preserve unknown, respect null in server-side block rendering.

• Skips validation where there is no attribute definition, but keeps the attribute value. Previously, the attribute would be omitted from the attributes passed to render_callback. Notably, this resolves an issue where render_callback cannot receive a block's align and customClassName attribute values, since these are defined as a client-side filter.
• Validates null as a proper value in its own right. Previously, a client implementation of a block could track {“attribute":null} as an explicitly empty value, and the server would wrongly initiate defaulting behavior. The new behavior will now only populate a default value if the attribute is not defined at all, including when unset in its being invalid per the attribute schema.

Props aduth, noisysocks, youknowriad, danielbachhuber.

Merges [43918] to trunk.

See #45145 for the patch, #45098 for the original ticket.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/blocks/block-type.php (modified) (3 diffs)

trunk/tests/phpunit/tests/blocks/block-type.php

@@ -169 +169 @@
             'wrongTypeDefaulted' => 5,
             /* missingDefaulted */
-            'undefined'          => 'omit',
+            'undefined'          => 'include',
+            'intendedNull'       => null,
         );
 
@@ -190 +191 @@
                         'default' => 'define',
                     ),
+                    'intendedNull'       => array(
+                        'type'    => array( 'string', 'null' ),
+                        'default' => 'wrong',
+                    ),
                 ),
             )
@@ -199 +204 @@
             array(
                 'correct'            => 'include',
-                'wrongType'          => null,
+                /* wrongType */
                 'wrongTypeDefaulted' => 'defaulted',
                 'missingDefaulted'   => 'define',
+                'undefined'          => 'include',
+                'intendedNull'       => null,
             ),
             $prepared_attributes
         );
+    }
+
+    /**
+     * @ticket 45145
+     */
+    function test_prepare_attributes_none_defined() {
+        $attributes = array( 'exists' => 'keep' );
+
+        $block_type = new WP_Block_Type( 'core/dummy', array() );
+
+        $prepared_attributes = $block_type->prepare_attributes_for_render( $attributes );
+
+        $this->assertEquals( $attributes, $prepared_attributes );
     }