Changeset 44269 for trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php

Timestamp:

12/17/2018 05:59:44 PM (6 years ago)

Author:

desrosj

Message:

REST API: Preserve unknown, respect null in server-side block rendering.

• Skips validation where there is no attribute definition, but keeps the attribute value. Previously, the attribute would be omitted from the attributes passed to render_callback. Notably, this resolves an issue where render_callback cannot receive a block's align and customClassName attribute values, since these are defined as a client-side filter.
• Validates null as a proper value in its own right. Previously, a client implementation of a block could track {“attribute":null} as an explicitly empty value, and the server would wrongly initiate defaulting behavior. The new behavior will now only populate a default value if the attribute is not defined at all, including when unset in its being invalid per the attribute schema.

Props aduth, noisysocks, youknowriad, danielbachhuber.

Merges [43918] to trunk.

See #45145 for the patch, #45098 for the original ticket.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/rest-api/rest-block-renderer-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-block-renderer-controller.php

@@ -320 +320 @@
         $defaults   = array();
         foreach ( $block_type->attributes as $key => $attribute ) {
-            $defaults[ $key ] = isset( $attribute['default'] ) ? $attribute['default'] : null;
+            if ( isset( $attribute['default'] ) ) {
+                $defaults[ $key ] = $attribute['default'];
+            }
         }