Changeset 44272 for trunk/tests/phpunit/tests/db.php

Timestamp:

12/17/2018 06:38:13 PM (3 years ago)

Author:

desrosj

Message:

WPDB: Check that $wpdb->last_result is countable before counting with it.

wpdb::get_col() iterates over $wpdb->last_result, which can be a non-countable value, should the preceding query have failed.

Props spacedmonkey, desrosj, pento.

Merges [43934] into trunk.

See #45299.

Location:

trunk

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/db.php (modified) (1 diff)

trunk/tests/phpunit/tests/db.php

@@ -569 +569 @@
         $this->assertInternalType( 'object', $row );
         $this->assertEquals( 'Walter Sobchak', $row->display_name );
+    }
+
+    /**
+     * Test the `get_col()` method.
+     *
+     * @param string|null        $query       The query to run.
+     * @param string|array       $expected    The expected resulting value.
+     * @param arrray|string|null $last_result The value to assign to `$wpdb->last_result`.
+     * @param int|string         $column      The column index to retrieve.
+     *
+     * @dataProvider data_test_get_col
+     *
+     * @ticket 45299
+     */
+    function test_get_col( $query, $expected, $last_result, $column ) {
+        global $wpdb;
+
+        $wpdb->last_result = $last_result;
+
+        $result = $wpdb->get_col( $query, $column );
+
+        if ( $query ) {
+            $this->assertSame( $query, $wpdb->last_query );
+        }
+
+        if ( is_array( $expected ) ) {
+            $this->assertSame( $expected, $result );
+        } else {
+            $this->assertContains( $expected, $result );
+        }
+    }
+
+    /**
+     * Data provider for testing `get_col()`.
+     *
+     * @return array {
+     *     Arguments for testing `get_col()`.
+     *
+     *     @type string|null        $query       The query to run.
+     *     @type string|array       $expected    The resulting expected value.
+     *     @type arrray|string|null $last_result The value to assign to `$wpdb->last_result`.
+     *     @type int|string         $column      The column index to retrieve.
+     */
+    function data_test_get_col() {
+        global $wpdb;
+
+        return array(
+            array(
+                "SELECT display_name FROM $wpdb->users",
+                'admin',
+                array(),
+                0,
+            ),
+            array(
+                "SELECT user_login, user_email FROM $wpdb->users",
+                'admin',
+                array(),
+                0,
+            ),
+            array(
+                "SELECT user_login, user_email FROM $wpdb->users",
+                'admin@example.org',
+                array(),
+                1,
+            ),
+            array(
+                "SELECT user_login, user_email FROM $wpdb->users",
+                'admin@example.org',
+                array(),
+                '1',
+            ),
+            array(
+                "SELECT user_login, user_email FROM $wpdb->users",
+                array( null ),
+                array(),
+                3,
+            ),
+            array(
+                '',
+                array(),
+                null,
+                0,
+            ),
+            array(
+                null,
+                array(),
+                '',
+                0,
+            ),
+        );
     }