Changeset 44297 for trunk

Timestamp:

12/18/2018 09:59:00 PM (6 years ago)

Author:

desrosj

Message:

PHP 7.3 Compatibility: Fix compact related notices.

In PHP 7.3, the compact() function has been changed to issue an E_NOTICE level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: ​https://wiki.php.net/rfc/compact.

See #44416.

Merges [44185] into trunk.

Fixes #45483.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/plugin-install.php (modified) (1 diff)
• src/wp-admin/includes/post.php (modified) (3 diffs)

trunk/src/wp-admin/includes/plugin-install.php

@@ -428 +428 @@
     $url         = false;
     $update_file = false;
+    $version     = '';
 
     /*

trunk/src/wp-admin/includes/post.php

@@ -1100 +1100 @@
 
     $avail_post_stati = get_available_post_statuses( $post_type );
+    $post_status      = '';
+    $perm             = '';
 
     if ( isset( $q['post_status'] ) && in_array( $q['post_status'], $post_stati ) ) {
@@ -1105 +1107 @@
         $perm        = 'readable';
     }
+
+    $orderby = '';
 
     if ( isset( $q['orderby'] ) ) {
@@ -1111 +1115 @@
         $orderby = 'modified';
     }
+
+    $order = '';
 
     if ( isset( $q['order'] ) ) {