Changeset 44298 for trunk/src/wp-content/themes/twentynineteen/header.php

Timestamp:

12/18/2018 10:08:33 PM (8 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Code Quality Improvements.

This change adds general code quality and documentation improvements.

More info here: ​https://github.com/WordPress/twentynineteen/pull/546

Props grapplerulrich, iCaleb, allancole.

Merges [44187] to trunk.

See #45424.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentynineteen/header.php (modified) (1 diff)

trunk/src/wp-content/themes/twentynineteen/header.php

@@ -32 +32 @@
                         <?php if ( is_singular() && twentynineteen_can_show_post_thumbnail() ) : ?>
                                 <div class="site-featured-image">
-                                        <?php twentynineteen_post_thumbnail(); ?>
-                                        <?php the_post(); ?>
-                                        <?php $discussion = ! is_page() && twentynineteen_can_show_post_thumbnail() ? twentynineteen_get_discussion_data() : null; ?>
-                                        <div class="<?php echo ( ! empty( $discussion ) && count( $discussion->responses ) > 0 ) ? 'entry-header has-discussion' : 'entry-header'; ?>">
+                                        <?php
+                                                twentynineteen_post_thumbnail();
+                                                the_post();
+                                                $discussion = ! is_page() && twentynineteen_can_show_post_thumbnail() ? twentynineteen_get_discussion_data() : null;
+
+                                                $classes = 'entry-header';
+                                        if ( ! empty( $discussion ) && count( $discussion->responses ) > 0 ) {
+                                                $classes = 'entry-header has-discussion';
+                                        }
+                                        ?>
+                                        <div class="<?php echo $classes; ?>">
                                                 <?php get_template_part( 'template-parts/header/entry', 'header' ); ?>
                                         </div><!-- .entry-header -->