Changeset 44305 for trunk/src/wp-content/themes/twentynineteen/header.php

Timestamp:

12/18/2018 10:45:16 PM (6 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github

.com/WordPress/twentynineteen/pull/47

• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217
• Fixes some minor code quality issues. ​https://github.com/WordPress/twentynineteen/pull/237
• Fix PHP Warning: Parameter must be an array or an object that implements Countable. ​https://github

.com/WordPress/twentynineteen/pull/661

• Add missing text domain and escaping to comment author text. ​https://github.com/WordPress/twentynineteen/pull/274
• Remove hyphens rule for cover image text. ​https://github.com/WordPress/twentynineteen/pull/691
• Fix left/right-aligned pullquote spacing. ​https://github.com/WordPress/twentynineteen/pull/695
• Improve readme.txt to follow the correct standards for themes. ​https://github.com/WordPress/twentynineteen/issues/689

Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj.

Merges [44196], [44199], and [44201-44202] into trunk.

Fixes #45424.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentynineteen/header.php (modified) (1 diff)

trunk/src/wp-content/themes/twentynineteen/header.php

@@ -38 +38 @@
 
                         $classes = 'entry-header';
-                    if ( ! empty( $discussion ) && count( $discussion->responses ) > 0 ) {
+                    if ( ! empty( $discussion ) && absint( $discussion->responses ) > 0 ) {
                         $classes = 'entry-header has-discussion';
                     }