Changeset 44305 for trunk/src/wp-content/themes/twentynineteen/inc/template-tags.php

Timestamp:

12/18/2018 10:45:16 PM (6 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github

.com/WordPress/twentynineteen/pull/47

• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217
• Fixes some minor code quality issues. ​https://github.com/WordPress/twentynineteen/pull/237
• Fix PHP Warning: Parameter must be an array or an object that implements Countable. ​https://github

.com/WordPress/twentynineteen/pull/661

• Add missing text domain and escaping to comment author text. ​https://github.com/WordPress/twentynineteen/pull/274
• Remove hyphens rule for cover image text. ​https://github.com/WordPress/twentynineteen/pull/691
• Fix left/right-aligned pullquote spacing. ​https://github.com/WordPress/twentynineteen/pull/695
• Improve readme.txt to follow the correct standards for themes. ​https://github.com/WordPress/twentynineteen/issues/689

Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj.

Merges [44196], [44199], and [44201-44202] into trunk.

Fixes #45424.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentynineteen/inc/template-tags.php (modified) (3 diffs)

trunk/src/wp-content/themes/twentynineteen/inc/template-tags.php

@@ -41 +41 @@
     function twentynineteen_posted_by() {
         printf(
+            /* translators: 1: SVG icon. 2: post author, only visible to screen readers. 3: author link. */
             '<span class="byline">%1$s<span class="screen-reader-text">%2$s</span><span class="author vcard"><a class="url fn n" href="%3$s">%4$s</a></span></span>',
-            /* translators: 1: SVG icon. 2: post author, only visible to screen readers. 3: author link. */
             twentynineteen_get_icon_svg( 'person', 16 ),
             __( 'Posted by', 'twentynineteen' ),
@@ -86 +86 @@
             $categories_list = get_the_category_list( __( ', ', 'twentynineteen' ) );
             if ( $categories_list ) {
-                /* translators: 1: SVG icon. 2: posted in label, only visible to screen readers. 3: list of categories. */
                 printf(
+                    /* translators: 1: SVG icon. 2: posted in label, only visible to screen readers. 3: list of categories. */
                     '<span class="cat-links">%1$s<span class="screen-reader-text">%2$s</span>%3$s</span>',
                     twentynineteen_get_icon_svg( 'archive', 16 ),
@@ -98 +98 @@
             $tags_list = get_the_tag_list( '', __( ', ', 'twentynineteen' ) );
             if ( $tags_list ) {
-                /* translators: 1: SVG icon. 2: posted in label, only visible to screen readers. 3: list of tags. */
                 printf(
+                    /* translators: 1: SVG icon. 2: posted in label, only visible to screen readers. 3: list of tags. */
                     '<span class="tags-links">%1$s<span class="screen-reader-text">%2$s </span>%3$s</span>',
                     twentynineteen_get_icon_svg( 'tag', 16 ),