Changeset 44305 for trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

Timestamp:

12/18/2018 10:45:16 PM (8 years ago)

Author:

desrosj

Message:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github

.com/WordPress/twentynineteen/pull/47

• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217
• Fixes some minor code quality issues. ​https://github.com/WordPress/twentynineteen/pull/237
• Fix PHP Warning: Parameter must be an array or an object that implements Countable. ​https://github

.com/WordPress/twentynineteen/pull/661

• Add missing text domain and escaping to comment author text. ​https://github.com/WordPress/twentynineteen/pull/274
• Remove hyphens rule for cover image text. ​https://github.com/WordPress/twentynineteen/pull/691
• Fix left/right-aligned pullquote spacing. ​https://github.com/WordPress/twentynineteen/pull/695
• Improve readme.txt to follow the correct standards for themes. ​https://github.com/WordPress/twentynineteen/issues/689

Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj.

Merges [44196], [44199], and [44201-44202] into trunk.

Fixes #45424.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss (modified) (7 diffs)

trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

@@ -325 +325 @@
                         margin-bottom: calc(4.33 * #{ $size__spacing-unit});
                         margin-right: 0;
+                        padding-left: 0;
                 }
 
@@ -363 +364 @@
 
                         blockquote {
-                                margin-left: 0;
+                                margin: $size__spacing-unit 0;
                                 padding: 0;
                                 text-align: left;
                                 max-width: 100%;
+
+                                p:first-child {
+                                        margin-top: 0;
+                                }
                         }
                 }
@@ -400 +405 @@
 
                         blockquote {
-                                max-width: calc(100% - (2 * #{$size__spacing-unit}));
+                                max-width: 100%;
                                 color: $color__background-body;
                                 padding-left: 0;
                                 margin-left: $size__spacing-unit;
+                                margin-right: $size__spacing-unit;
 
                                 &.has-text-color p,
@@ -418 +424 @@
                                         margin-left: 0;
                                         margin-right: 0;
+                                }
+                        }
+
+                        &.alignright,
+                        &.alignleft {
+
+                                @include media(tablet) {
+                                        padding: $size__spacing-unit calc(2 * #{$size__spacing-unit});
                                 }
                         }
@@ -529 +543 @@
                         padding: 0;
                         color: #fff;
-                        -ms-hyphens: auto;
-                        -moz-hyphens: auto;
-                        -webkit-hyphens: auto;
-                        hyphens: auto;
 
                         @include media(tablet) {
@@ -545 +555 @@
 
                         @include media(tablet) {
-                                padding: $size__spacing-unit;
+                                padding: $size__spacing-unit calc(2 * #{$size__spacing-unit});
                         }
                 }
@@ -578 +588 @@
                 .blocks-gallery-item:last-child {
                         margin-bottom: 16px;
+                }
+
+                figcaption a {
+                        color: #fff;
                 }
         }