Changeset 44339 for branches/5.0/src/wp-admin/includes/post.php

Timestamp:

12/19/2018 10:27:51 PM (6 years ago)

Author:

desrosj

Message:

Posts, Post Types: Correctly show hierarchical post type hierarchy in admin.

In [44185], a bug was introduced where hierarchical post types would not display in the correct default order (hierarchically).

This was caused by a ! isset() check, which returned false after [44185], causing the correct default value to not be applied. This switches that conditional to use an empty() check, ignoring the new empty string assignment that was added to prevent a PHP notice when compact() is called.

Merges [44338] to the 5.0 branch.

Props davidbinda.
Fixes #45711.

Location:

branches/5.0

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/post.php (modified) (1 diff)

branches/5.0/src/wp-admin/includes/post.php

@@ -1087 +1087 @@
 
     // Hierarchical types require special args.
-    if ( is_post_type_hierarchical( $post_type ) && !isset($orderby) ) {
+    if ( is_post_type_hierarchical( $post_type ) && empty( $orderby ) ) {
         $query['orderby'] = 'menu_order title';
         $query['order'] = 'asc';