Changeset 44358

Timestamp:

12/21/2018 09:35:48 PM (6 years ago)

Author:

laurelfulford

Message:

Twenty Nineteen: Make sure links are followed on touchend, not touchstart.

The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.

Already committed to the 5.0 branch in [44357].

Props anevins, panchen, kjellr.
Fixes #45510.

File:

• trunk/src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js (modified) (1 diff)

trunk/src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js

@@ -220 +220 @@
                 var url = event.target.getAttribute( 'href' ) ? event.target.getAttribute( 'href' ) : '';
 
-                // If there’s a link, go to it on touchend
-                if ( '#' !== url && '' !== url ) {
-                    window.location = url;
-
                 // Open submenu if url is #
-                } else if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {
-
+                if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {
                     openSubMenu( event.target );
-
-                // Prevent default touch events
-                } else {
-
-                    event.preventDefault();
                 }
             }