Changeset 4438 for trunk/wp-includes/functions.php

Timestamp:

10/31/2006 08:24:09 AM (20 years ago)

Author:

markjaquith

Message:

Catch NULL, bool, and integer values in is_serialized(). Props mdawaffe. fixes #3310

File:

• trunk/wp-includes/functions.php (modified) (2 diffs)

trunk/wp-includes/functions.php

@@ -164 +164 @@
 
 function is_serialized($data) {
-        if ( !is_string($data) ) // if it isn't a string, it isn't serialized
+        // if it isn't a string, it isn't serialized
+        if ( !is_string($data) )
                 return false;
         $data = trim($data);
-        if ( preg_match("/^[adobis]:[0-9]+:.*[;}]/si",$data) ) // this should fetch all legitimately serialized data
+        if ( 'N;' == $data )
                 return true;
+        if ( !preg_match('/^([adObis]):/', $data, $badions) )
+                return false;
+        switch ( $badions[1] ) :
+        case 'a' :
+        case 'O' :
+        case 's' :
+                if ( preg_match("/^{$badions[1]}:[0-9]+:.*[;}]\$/s", $data) )
+                        return true;
+                break;
+        case 'b' :
+        case 'i' :
+        case 'd' :
+                if ( preg_match("/^{$badions[1]}:[0-9.E-]+;\$/", $data) )
+                        return true;
+                break;
+        endswitch;
         return false;
 }
 
 function is_serialized_string($data) {
-        if ( !is_string($data) ) // if it isn't a string, it isn't a serialized string
+        // if it isn't a string, it isn't a serialized string
+        if ( !is_string($data) )
                 return false;
         $data = trim($data);
-        if ( preg_match("/^s:[0-9]+:.*[;}]/si",$data) ) // this should fetch all serialized strings
+        if ( preg_match('/^s:[0-9]+:.*;$/s',$data) ) // this should fetch all serialized strings
                 return true;
         return false;
@@ -1203 +1221 @@
         return $input;
 }
-
 ?>