Changeset 44392

Timestamp:

01/04/2019 08:29:41 PM (6 years ago)

Author:

desrosj

Message:

Customize: Safeguard a check on the customize_validate_{$setting_id} filter value to ensure it is a WP_Error.

While the filter is documented to only support a WP_Error, it has been a common practice to return true in a validation function if no errors have occurred. This was already caught when the same filter was executed in WP_Customize_Setting, it was however missing in WP_Customize_Manager::validate_setting_values().

Props flixos90.

Merges [43578] to the 5.0 branch.
Fixes #44809.

Location:

branches/5.0

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-customize-manager.php (modified) (1 diff)

branches/5.0/src/wp-includes/class-wp-customize-manager.php

@@ -2285 +2285 @@
                 /** This filter is documented in wp-includes/class-wp-customize-setting.php */
                 $late_validity = apply_filters( "customize_validate_{$setting->id}", new WP_Error(), $unsanitized_value, $setting );
-                if ( ! empty( $late_validity->errors ) ) {
+                if ( is_wp_error( $late_validity ) && ! empty( $late_validity->errors ) ) {
                     $validity = $late_validity;
                 }