Changeset 44409 for branches/5.0/src/wp-content/themes/twentyseventeen/functions.php

Timestamp:

01/06/2019 08:18:08 PM (6 years ago)

Author:

desrosj

Message:

Twenty Seventeen: Use a simple counter incremented with each call instead of uniqid() for generating unique IDs for HTML elements.

Props westonruter, laurelfulford.

Merges [43659] and [44408] to the 5.0 branch.
Fixes #44883.

Location:

branches/5.0

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentyseventeen/functions.php (modified) (1 diff)

branches/5.0/src/wp-content/themes/twentyseventeen/functions.php

@@ -587 +587 @@
 
 /**
+ * Get unique ID.
+ *
+ * This is a PHP implementation of Underscore's uniqueId method. A static variable
+ * contains an integer that is incremented with each call. This number is returned
+ * with the optional prefix. As such the returned value is not universally unique,
+ * but it is unique across the life of the PHP process.
+ *
+ * @since Twenty Seventeen 2.0
+ * @see wp_unique_id() Themes requiring WordPress 5.0.3 and greater should use this instead.
+ *
+ * @staticvar int $id_counter
+ *
+ * @param string $prefix Prefix for the returned ID.
+ * @return string Unique ID.
+ */
+function twentyseventeen_unique_id( $prefix = '' ) {
+    static $id_counter = 0;
+    if ( function_exists( 'wp_unique_id' ) ) {
+        return wp_unique_id( $prefix );
+    }
+    return $prefix . (string) ++$id_counter;
+}
+
+/**
  * Implement the Custom Header feature.
  */