Changeset 44427

Timestamp:

01/07/2019 04:01:23 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Twenty Nineteen: Remove transparency from submenus.

On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance.

Props kjellr.
Merges [44368] to the 5.0 branch.
Fixes #45689.

Location:

branches/5.0

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss (modified) (1 diff)
• src/wp-content/themes/twentynineteen/sass/site/header/_site-featured-image.scss (modified) (1 diff)
• src/wp-content/themes/twentynineteen/style-rtl.css (modified) (2 diffs)
• src/wp-content/themes/twentynineteen/style.css (modified) (2 diffs)

branches/5.0/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss

@@ -203 +203 @@
                 display: block;
                 line-height: $font__line-height-heading;
+                text-shadow: none;
                 padding: calc( .5 * #{$size__spacing-unit} ) calc( 24px + #{$size__spacing-unit} ) calc( .5 * #{$size__spacing-unit} ) $size__spacing-unit;
                 white-space: nowrap;

branches/5.0/src/wp-content/themes/twentynineteen/sass/site/header/_site-featured-image.scss

@@ -44 +44 @@
             color: $color__background-body;
         }
+    }
+
+    .main-navigation .sub-menu a {
+        opacity: inherit;
     }
 

branches/5.0/src/wp-content/themes/twentynineteen/style-rtl.css

@@ -1222 +1222 @@
   display: block;
   line-height: 1.2;
+  text-shadow: none;
   padding: calc( .5 * 1rem) 1rem calc( .5 * 1rem) calc( 24px + 1rem);
   white-space: nowrap;
@@ -2194 +2195 @@
 .site-header.featured-image .site-featured-image a:focus + svg {
   color: #fff;
+}
+
+.site-header.featured-image .main-navigation .sub-menu a {
+  opacity: inherit;
 }
 

branches/5.0/src/wp-content/themes/twentynineteen/style.css

@@ -1222 +1222 @@
   display: block;
   line-height: 1.2;
+  text-shadow: none;
   padding: calc( .5 * 1rem) calc( 24px + 1rem) calc( .5 * 1rem) 1rem;
   white-space: nowrap;
@@ -2200 +2201 @@
 .site-header.featured-image .site-featured-image a:focus + svg {
   color: #fff;
+}
+
+.site-header.featured-image .main-navigation .sub-menu a {
+  opacity: inherit;
 }