Changeset 44437 for trunk

Timestamp:

01/07/2019 08:39:56 PM (6 years ago)

Author:

desrosj

Message:

Block Editor: Display notice to the user when JavaScript is disabled.

Currently, when viewing the block editor with JavaScript disabled, the user sees a blank admin page with the admin menu sidebar. This adds an admin notice informing the user that JavaScript is required for the new block editor.

Props mkaz, pento, azaozz, ocean90, desrosj.
Fixes #45453.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (1 diff)
• edit-form-blocks.php (modified) (2 diffs)
• post.php (modified) (2 diffs)

trunk/src/wp-admin/css/common.css

@@ -559 +559 @@
 .wrap {
     margin: 10px 20px 0 2px;
+}
+
+.wrap.block-editor-no-js {
+    padding-left: 20px;
 }
 

trunk/src/wp-admin/edit-form-blocks.php

@@ -23 +23 @@
  */
 global $post_type, $post_type_object, $post, $title, $editor_styles, $wp_meta_boxes;
-
-if ( ! empty( $post_type_object ) ) {
-    $title = $post_type_object->labels->edit_item;
-}
 
 // Flag that we're loading the block editor.
@@ -400 +396 @@
 
 <div class="block-editor">
-    <h1 class="screen-reader-text"><?php echo esc_html( $post_type_object->labels->edit_item ); ?></h1>
-    <div id="editor" class="block-editor__container"></div>
+    <h1 class="screen-reader-text hide-if-no-js"><?php echo esc_html( $title ); ?></h1>
+    <div id="editor" class="block-editor__container hide-if-no-js"></div>
     <div id="metaboxes" class="hidden">
         <?php the_block_editor_meta_boxes(); ?>
     </div>
+
+    <?php // JavaScript is disabled. ?>
+    <div class="wrap hide-if-js block-editor-no-js">
+        <h1 class="wp-heading-inline"><?php echo esc_html( $title ); ?></h1>
+        <div class="notice notice-error notice-alt">
+            <p>
+                <?php
+                    $message = sprintf(
+                        /* translators: %s: https://wordpress.org/plugins/classic-editor/ */
+                        __( 'The block editor requires JavaScript. Please enable JavaScript in your browser settings, or try the <a href="%s">Classic Editor plugin</a>.' ),
+                        __( 'https://wordpress.org/plugins/classic-editor/' )
+                    );
+
+                    /**
+                     * Filters the message displayed in the block editor interface when JavaScript is
+                     * not enabled in the browser.
+                     *
+                     * @since 5.0.3
+                     *
+                     * @param string  $message The message being displayed.
+                     * @param WP_Post $post    The post being edited.
+                     */
+                    echo apply_filters( 'block_editor_no_javascript_message', $message, $post );
+                    ?>
+            </p>
+        </div>
+    </div>
 </div>

trunk/src/wp-admin/post.php

@@ -155 +155 @@
         }
 
+        $title = $post_type_object->labels->edit_item;
+
         /**
          * Allows replacement of the editor.
@@ -180 +182 @@
         }
 
-        $title = $post_type_object->labels->edit_item;
-        $post  = get_post( $post_id, OBJECT, 'edit' );
+        $post = get_post( $post_id, OBJECT, 'edit' );
 
         if ( post_type_supports( $post_type, 'comments' ) ) {