Changeset 44438 for trunk/tests/phpunit/tests/functions.php

Timestamp:

01/07/2019 08:47:56 PM (7 years ago)

Author:

joemcgill

Message:

Upload: Fix upload failures of common text file types.

This adds some special case handling in 'wp_check_filetype_and_ext()' that prevents some common file types from being blocked based on mismatched MIME checks, which were made more strict in WordPress 5.0.1.

Props Kloon, birgire, tellyworth, joemcgill.
See #45615.

File:

• trunk/tests/phpunit/tests/functions.php (modified) (2 diffs)

trunk/tests/phpunit/tests/functions.php

@@ -1231 +1231 @@
 
     /**
-     * Data profider for test_wp_get_image_mime();
+     * Data provider for test_wp_get_image_mime();
      */
     public function _wp_get_image_mime() {
@@ -1334 +1334 @@
                     'ext'             => false,
                     'type'            => false,
+                    'proper_filename' => false,
+                ),
+            ),
+            // Non-image file not allowed even if it's named like one.
+            array(
+                DIR_TESTDATA . '/export/crazy-cdata.xml',
+                'crazy-cdata.jpg',
+                array(
+                    'ext' => false,
+                    'type' => false,
+                    'proper_filename' => false,
+                ),
+            ),
+            // Non-image file not allowed if it's named like something else.
+            array(
+                DIR_TESTDATA . '/export/crazy-cdata.xml',
+                'crazy-cdata.doc',
+                array(
+                    'ext' => false,
+                    'type' => false,
+                    'proper_filename' => false,
+                ),
+            ),
+            // Assorted text/* sample files
+            array(
+                DIR_TESTDATA . '/uploads/test.vtt',
+                'test.vtt',
+                array(
+                    'ext' => 'vtt',
+                    'type' => 'text/vtt',
+                    'proper_filename' => false,
+                ),
+            ),
+            array(
+                DIR_TESTDATA . '/uploads/test.csv',
+                'test.csv',
+                array(
+                    'ext' => 'csv',
+                    'type' => 'text/csv',
+                    'proper_filename' => false,
+                ),
+            ),
+            // RTF files.
+            array(
+                DIR_TESTDATA . '/uploads/test.rtf',
+                'test.rtf',
+                array(
+                    'ext' => 'rtf',
+                    'type' => 'application/rtf',
                     'proper_filename' => false,
                 ),